Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for interaction between pseudoclasses and widget-level render caches #2155

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Fix for interaction between pseudoclasses and widget-level render caches #2155

merged 6 commits into from
Mar 28, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Mar 28, 2023 •
edited
Loading

  • Add Widget.get_pseudo_class_state which returns a named tuple of bools indicating the pseudo-classes that are relevant for the widget. This can be used as a cache-key to simplify invalidation of cache entries in widgets that have internal caches (e.g. Tree and DataTable).
  • Update Tree and DataTable to use the pseudo-class state in their cache keys.
  • Hide the hover cursor when the mouse cursor leaves the DataTable.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@willmcgugan willmcgugan merged commit 17c6f3f into main Mar 28, 2023
@willmcgugan willmcgugan deleted the 1879-focus-bug branch March 28, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenburns @willmcgugan